Register client alias to support Symfony 5.3 Target attribute #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you are using Symfony 5.3 and you have multiple clients defined, you can use the `Target`
attribute to select the client that you want.
Example:
```php
final class MyService
{
public function __construct(
#[Target('my_client_alias')] HttpClient $client
) {}
}
```
It will now automatically inject `httplug.client.my_client_alias`.
For more information:
https://symfony.com/blog/new-in-symfony-5-3-service-autowiring-with-attributes
|
could you add a note in https://github.com/php-http/documentation/blob/master/integrations/symfony-bundle.rst#usage that the bundle supports the target attribute? |
|
@dbu Thanks for merging it. I created the PR to improve the docs php-http/documentation#287. When you have time could you please create a new tagged release? Thanks 🙏 |
|
thanks for the contribution and the documentation. i just tagged 1.21.0 with this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
When you are using Symfony 5.3 and you have multiple clients defined, you can use the
Targetattribute to select the client that you want.
Why?
Improve Developer Experience.
Example Usage
Example:
It will now automatically inject
httplug.client.my_client_alias.For more information:
https://symfony.com/blog/new-in-symfony-5-3-service-autowiring-with-attributes
Checklist